Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

[L2-UX] new Stepper and StepperForm component #2683

Merged
merged 14 commits into from
Sep 8, 2021
Merged

[L2-UX] new Stepper and StepperForm component #2683

merged 14 commits into from
Sep 8, 2021

Conversation

DaniSomoza
Copy link
Contributor

@DaniSomoza DaniSomoza commented Aug 27, 2021 •
edited
Loading

What it solves

Resolves #2631 & #2668

How this PR fixes it

Implementation of a new Stepper and StepperForm Component to fix #2668

How to test it

Screenshots

@DaniSomoza DaniSomoza added the WIP label Aug 27, 2021
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Aug 27, 2021 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 2 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1174185738

Failed tests:

  • ❌ Add an existing safe Add an existing safe

@github-actions
Copy link

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1181730470

Failed tests:

  • ❌ Add an existing safe Add an existing safe

@github-actions
Copy link

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1181814057

Failed tests:

  • ❌ Add an existing safe Add an existing safe

@github-actions
Copy link

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1181861188

Failed tests:

  • ❌ Add an existing safe Add an existing safe

@github-actions
Copy link

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1182976695

Failed tests:

  • ❌ Add an existing safe Add an existing safe

@github-actions
Copy link

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1185643913

Failed tests:

  • ❌ Add an existing safe Add an existing safe

@github-actions
Copy link

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1186320638

Failed tests:

  • ❌ Add an existing safe Add an existing safe

@github-actions
Copy link

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1186680750

Failed tests:

  • ❌ Add an existing safe Add an existing safe

@DaniSomoza DaniSomoza changed the title [L2-UX] Network selection popup [L2-UX] new Stepper and StepperForm component Sep 2, 2021
@github-actions
Copy link

github-actions bot commented Sep 2, 2021

E2E Tests Passed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1194094816

@github-actions
Copy link

github-actions bot commented Sep 2, 2021

E2E Tests Passed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1194604676

@github-actions
Copy link

github-actions bot commented Sep 2, 2021

E2E Tests Passed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1195046071

@github-actions
Copy link

github-actions bot commented Sep 3, 2021

E2E Tests Passed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1197446793

@github-actions
Copy link

github-actions bot commented Sep 3, 2021

E2E Tests Passed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1197479951

@DaniSomoza DaniSomoza removed the WIP label Sep 3, 2021
@DaniSomoza DaniSomoza marked this pull request as ready for review September 3, 2021 09:55
katspaugh
katspaugh approved these changes Sep 3, 2021
View reviewed changes
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

src/components/NewStepper/Stepper.tsx Outdated
import Paper from '@material-ui/core/Paper'
import { makeStyles } from '@material-ui/core/'

import Hairline from '../layout/Hairline'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following imports use an absolute path, so maybe here as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@DaniSomoza DaniSomoza mentioned this pull request Sep 6, 2021
Merged
@DaniSomoza DaniSomoza changed the base branch from feature/refactor-network-config-getters to l2-ux September 7, 2021 13:14
@DaniSomoza DaniSomoza force-pushed the feature/network-selection-popup branch from 6e7f59f to 610f58b Compare September 8, 2021 10:06
@github-actions
Copy link

github-actions bot commented Sep 8, 2021

E2E Tests Passed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1212903096

@DaniSomoza DaniSomoza merged commit 6efb0e1 into l2-ux Sep 8, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2021
@dasanra dasanra deleted the feature/network-selection-popup branch October 20, 2021 15:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katspaugh katspaugh katspaugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniSomoza @katspaugh