Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Feature: Add Tooltip component #92

Merged
merged 2 commits into from
Feb 11, 2021
Merged

Feature: Add Tooltip component #92

merged 2 commits into from
Feb 11, 2021

Conversation

nicosampler
Copy link
Contributor

This component is required in SR for tx-v2.

@nicosampler nicosampler self-assigned this Feb 11, 2021
@ghost
Copy link

ghost commented Feb 11, 2021

Travis automatic deployment:
https://pr92--safereactcomponents.review.gnosisdev.com

alongoni
alongoni reviewed Feb 11, 2021
View reviewed changes
Copy link
Contributor

@alongoni alongoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!
We can add a placement options via props. E.g.: top, right, bottom, left

@nicosampler
Copy link
Contributor Author

Looks Good!
We can add a placement options via props. E.g.: top, right, bottom, left

we already have it.

fernandomg
fernandomg approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@fernandomg fernandomg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nice

@fernandomg fernandomg merged commit ab12701 into development Feb 11, 2021
@fernandomg fernandomg deleted the add-tooltip-component branch February 11, 2021 16:34
@nicosampler nicosampler mentioned this pull request Feb 14, 2021
Closed
@dasanra dasanra mentioned this pull request Feb 18, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alongoni alongoni alongoni approved these changes

@fernandomg fernandomg fernandomg approved these changes

@matextrem matextrem matextrem approved these changes

@Agupane Agupane Awaiting requested review from Agupane

@dasanra dasanra Awaiting requested review from dasanra

Assignees

@nicosampler nicosampler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicosampler @alongoni @fernandomg @matextrem