Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

(Fix) remove background color and center icons from Tabs component #87

Merged
merged 2 commits into from
Jan 13, 2021

Conversation

alongoni
Copy link
Contributor

@alongoni alongoni commented Jan 4, 2021

Closed #86
image

@alongoni alongoni self-assigned this Jan 4, 2021
@github-actions
Copy link

github-actions bot commented Jan 4, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Jan 4, 2021

Travis automatic deployment:
https://pr87--safereactcomponents.review.gnosisdev.com

Copy link
Contributor

@fernandomg fernandomg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a border-bottom prop, that must be removed:

image

@fernandomg
Copy link
Contributor

there's a border-bottom prop, that must be removed:

hmm... now that I see the requirements, it seems to be required. But I'm not sure if the width is correct (@alongoni, thoughts?)

image

@ghost
Copy link

ghost commented Jan 8, 2021

Travis automatic deployment:
https://pr87--safereactcomponents.review.gnosisdev.com

@fernandomg fernandomg self-requested a review January 11, 2021 17:58
Copy link
Contributor

@fernandomg fernandomg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@fernandomg fernandomg merged commit 420f595 into development Jan 13, 2021
@fernandomg fernandomg deleted the issue#86-tab branch January 13, 2021 18:48
@dasanra dasanra mentioned this pull request Feb 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set transparent background for Tabs component
4 participants