Components modification for new TXs tab. #37
Conversation
nicosampler
requested review from
alongoni,
fernandomg,
mmv08,
Agupane and
dasanra
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
ESLint Summary View Full Report
[warning] @typescript-eslint/no-unused-vars
[warning] @typescript-eslint/no-explicit-any
Report generated by eslint-plus-action |
|
Travis automatic deployment: |
1 similar comment
|
Travis automatic deployment: |
|
@mikheevm , I'm completely agreed on using this new linter, but we should not add it in a feature. we should add it in a new PR, because we have to fix a lot of code not related to the intention of the feature |
|
@nicosampler it lints changed files in a PR and the changes in PR should follow ESLint rules |
|
Travis automatic deployment: |
|
@mikheevm I fixed the errors for the files related to this PR. Other fixes should be done in another PR. |
|
@nicosampler please fix other easy-to-fix issues (like prettier) |
|
Travis automatic deployment: |
|
Please fix other easy to fix issues like no return types, unused vars, etc, it shouldn't take that long |
|
@mikheevm done! |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
| <FixedDialog | ||
| title="Legal Disclaimer" | ||
| body={<div>Some Body</div>} | ||
| onCancel={() => {}} | ||
| onConfirm={() => {}} | ||
| onCancel={() => undefined} |
There was a problem hiding this comment.
if we use console.log shouldn't it be a little noisy in production?
|
|
||
|
|
||
| ].map((type: any, index) => ( | ||
| {icons.map((type, index) => ( | ||
| <IconBox key={index}> |
There was a problem hiding this comment.
could've used type as a key. This makes no different in this case, but just fyi
There was a problem hiding this comment.
not sure to understand? could you give me an example?
There was a problem hiding this comment.
ohh yes! I was thinking about something with TS.
src/feedback/StatusDot/index.tsx
Outdated
| color: keyof Theme['colors']; | ||
| size: keyof Theme['statusDot']['size']; |
There was a problem hiding this comment.
Could be exported to a separate type
| @@ -22,7 +22,7 @@ const Button = ({ | |||
| color, | |||
| variant, | |||
| ...rest | |||
| }: Props) => { | |||
| }: Props): React.ReactElement => { | |||
There was a problem hiding this comment.
please remove any in props for this component
|
Travis automatic deployment: |
|
@mikheevm done! |
|
Travis automatic deployment: |
Closes Issue #36.