Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Cleanup fonts #206

Merged
merged 6 commits into from
Aug 12, 2022
Merged

Cleanup fonts #206

merged 6 commits into from
Aug 12, 2022

Conversation

dasanra
Copy link
Collaborator

@dasanra dasanra commented Aug 12, 2022

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 12, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

📚 Storybook review

@dasanra dasanra merged commit d08553c into main Aug 12, 2022
@dasanra dasanra deleted the release/v0.10.0 branch August 12, 2022 14:02
@bh2smith
Copy link

bh2smith commented Sep 1, 2022

This change appears to be causing an issue with dependency updates (version bumps to from v1.1.5 to v1.2.0)

➜  safe-airdrop git:(bump-safe-deps-2) yarn build
yarn run v1.22.19
$ react-app-rewired build
Creating an optimized production build...
Failed to compile.

./src/GlobalStyle.ts
Cannot find module: '@gnosis.pm/safe-react-components/dist/fonts/averta-bold.woff2'. Make sure this package is installed.

You can install this package by running: yarn add @gnosis.pm/safe-react-components/dist/fonts/averta-bold.woff2.


error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Is there some expected plan of action for those? Are we to stop using this font in our safe apps?

Was there any particular reason for deleting these fonts? Could they be put back?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants