Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

style: Adjust EthHashInfo name font weight #182

Merged
merged 3 commits into from
Jan 31, 2022
Merged

Conversation

usame-algan
Copy link
Member

Goal

In order to conform with the redesign of Tx Modals the name in EthHashInfo should be bold.

Screenshot

@usame-algan usame-algan requested a review from iamacook January 31, 2022 11:08
@usame-algan
Copy link
Member Author

We might want to use a prop for this in case the name should not be bold in some places.

Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not set this as strong by default but instead pass it as a prop. This component is used across the entire Safe so this change would affect multiple places.

@github-actions
Copy link

github-actions bot commented Jan 31, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

📚 Storybook review

Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be best to adhere to the targetted props, i.e. strongName but that is personal preference

Looking good, nonetheless.

@usame-algan usame-algan merged commit 3b0f0ce into main Jan 31, 2022
@usame-algan usame-algan deleted the eth-hash-info-font branch January 31, 2022 11:40
@usame-algan usame-algan restored the eth-hash-info-font branch January 31, 2022 11:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants