Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Feature - Checkbox label supports passing a node #126

Merged
merged 2 commits into from
Apr 27, 2021

Conversation

matextrem
Copy link
Contributor

Since MaterialUI supports passing a node as label, we consider it important to add support for the checkbox component to receive a node for label prop

@matextrem matextrem added the enhancement New feature or request label Apr 27, 2021
@matextrem matextrem requested review from fernandomg and mmv08 April 27, 2021 14:16
@matextrem matextrem self-assigned this Apr 27, 2021
@github-actions
Copy link

github-actions bot commented Apr 27, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 3 0
Ignored 0 N/A
  • Result: ✅ success

  • Annotations: 3 total


[warning] @typescript-eslint/no-explicit-any

Disallow usage of the any type


Report generated by eslint-plus-action

@matextrem matextrem requested a review from mmv08 April 27, 2021 14:35
@ghost
Copy link

ghost commented Apr 27, 2021

Travis automatic deployment:
https://pr126--safereactcomponents.review.gnosisdev.com

1 similar comment
@ghost
Copy link

ghost commented Apr 27, 2021

Travis automatic deployment:
https://pr126--safereactcomponents.review.gnosisdev.com

@fernandomg
Copy link
Contributor

fernandomg commented Apr 27, 2021

@matextrem, can you check what's happening with this PR? there are several changes
image

I don't think that's ok

Probably your base branch was outdated. Try rebasing with development and push --force your changes

@ghost
Copy link

ghost commented Apr 27, 2021

Travis automatic deployment:
https://pr126--safereactcomponents.review.gnosisdev.com

@matextrem matextrem force-pushed the feature/checkbox-label branch from aabb3c4 to b118de6 Compare April 27, 2021 14:59
@ghost
Copy link

ghost commented Apr 27, 2021

Travis automatic deployment:
https://pr126--safereactcomponents.review.gnosisdev.com

@fernandomg
Copy link
Contributor

@matextrem, can you add an example in the storybook for the node-like label?

@mmv08
Copy link
Member

mmv08 commented Apr 27, 2021

@fernandomg

    type ReactText = string | number;
    type ReactChild = ReactElement | ReactText;
    type ReactNode = ReactChild | ReactFragment | ReactPortal | boolean | null | undefined;

current example is already a node :)

@mmv08 mmv08 merged commit fed840e into development Apr 27, 2021
@mmv08 mmv08 deleted the feature/checkbox-label branch April 27, 2021 19:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants