Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Feature: EthHasInfo add showHash property #120

Merged
merged 4 commits into from
Apr 23, 2021

Conversation

nicosampler
Copy link
Contributor

  • It is no possible not to render the hash but render the Identicon. That's why I added the showHash prop.
  • Adding a border-radius of 50% was breaking some SVGs. If that is needed should be customized when the Component is being used.

@nicosampler nicosampler self-assigned this Apr 23, 2021
@github-actions
Copy link

github-actions bot commented Apr 23, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Please update the snapshots.

@liliya-soroka
Copy link
Member

@nicosampler , could you provide more details about where and how it influences on the app ? It really hard to understand how and where to test. Why do we change it ? Is it related to some issue?

@ghost
Copy link

ghost commented Apr 23, 2021

Travis automatic deployment:
https://pr120--safereactcomponents.review.gnosisdev.com

@mmv08
Copy link
Member

mmv08 commented Apr 23, 2021

@nicosampler
Copy link
Contributor Author

@liliya-soroka, this is a stand-alone component. Not directly related to safe-react repository.
So far we are not requiring manual testing here as the outcome will impact the tickets in safe-react, so testing the tickets in safe-react would cover these components.

@nicosampler nicosampler force-pushed the EthHashInfo-modifications branch from 1cbb25d to fcedd67 Compare April 23, 2021 11:53
@katspaugh
Copy link
Member

I've filed #122 to fix the tests.

@ghost
Copy link

ghost commented Apr 23, 2021

Travis automatic deployment:
https://pr120--safereactcomponents.review.gnosisdev.com

1 similar comment
@ghost
Copy link

ghost commented Apr 23, 2021

Travis automatic deployment:
https://pr120--safereactcomponents.review.gnosisdev.com

@nicosampler nicosampler merged commit 5a4b1fe into development Apr 23, 2021
@nicosampler nicosampler deleted the EthHashInfo-modifications branch April 23, 2021 12:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants