Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix key props; update tests #117

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Fix key props; update tests #117

merged 1 commit into from
Apr 23, 2021

Conversation

katspaugh
Copy link
Member

The Table and FixedIcon components had a wrong key prop.
I've also updated the snapshots by running yarn test -u.

How to test

  • Open the Table story on localhost
  • It shouldn't log a warning about the "key" prop

@katspaugh katspaugh requested a review from alongoni April 21, 2021 07:24
@katspaugh katspaugh self-assigned this Apr 21, 2021
@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Apr 21, 2021

Travis automatic deployment:
https://pr117--safereactcomponents.review.gnosisdev.com

@katspaugh katspaugh requested a review from dasanra April 22, 2021 07:37
@katspaugh
Copy link
Member Author

No QA needed, it's just a tiny fix for the React warnings.

@katspaugh katspaugh merged commit f8a26d7 into development Apr 23, 2021
@katspaugh katspaugh deleted the fix-keys branch April 23, 2021 09:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants