Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define use of executionMeta field in Guard/Hooks interface #10

Closed
akshay-ap opened this issue Jul 7, 2023 · 1 comment · Fixed by #37
Closed

Define use of executionMeta field in Guard/Hooks interface #10

akshay-ap opened this issue Jul 7, 2023 · 1 comment · Fixed by #37
Assignees
@akshay-ap

Comments

@akshay-ap
Copy link
Contributor

With current protocol spec, it is not clear what information is passed in executionMeta field of Gaurd/hooks interface.
How should a guard/hook process this information?
https://github.com/5afe/safe-protocol-specs/tree/main/components#guards-hooks
@rmeissner
Copy link
Member

The execution meta should contain information about the execution flow. I.e. if it is triggered via the multisig flow of Safe it should contain information for this flow. Or if it is a module flow, it should contain information about it (like the module address).

@akshay-ap akshay-ap mentioned this issue Jul 10, 2023
Merged
15 tasks
@rmeissner rmeissner self-assigned this Jul 10, 2023
@rmeissner rmeissner assigned akshay-ap and unassigned rmeissner Aug 28, 2023
akshay-ap added a commit that referenced this issue Sep 8, 2023
@akshay-ap
[#10] Document executionMeta parameter value
14e9fd3
@akshay-ap akshay-ap mentioned this issue Sep 8, 2023
Merged
akshay-ap added a commit that referenced this issue Sep 22, 2023
@akshay-ap
[#10] Update executionMeta value description
5f13cec
akshay-ap added a commit that referenced this issue Sep 22, 2023
@akshay-ap
[#10] Fix extra whitespace
e38a227
akshay-ap added a commit that referenced this issue Sep 22, 2023
@akshay-ap
Document executionMeta parameter value (#37)
fd2da5a 
* [#10] Document executionMeta parameter value

* [#10] Update executionMeta value description

* [#10] Fix extra whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akshay-ap akshay-ap

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document executionMeta parameter value 5afe/safe-core-protocol-specs
2 participants
@rmeissner @akshay-ap