Estimate tx gas #50
Merged
Estimate tx gas #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reference to batching transactions issue: ethers-io/ethers.js#62 |
germartinez
requested changes
May 4, 2020
| sendOptions: { | ||
| gasLimit?: number | string; | ||
| } | ||
| ): Promise<EthersTransactionResult>; |
There was a problem hiding this comment.
EthersTransactionResult | Web3TransactionResult
| @@ -192,6 +237,17 @@ class CPKEthersProvider implements CPKProvider { | |||
| getSendOptions(options: object, ownerAccount: string): object { | |||
| return options; | |||
| } | |||
|
|
|||
| async getGasPrice(): Promise<number> { | |||
| @@ -173,6 +266,15 @@ class CPKWeb3Provider implements CPKProvider { | |||
| ...(options || {}), | |||
| }; | |||
| } | |||
|
|
|||
| getGasPrice() { | |||
|
I just saw that this is fixed in the next PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit notes:
Discovered that
eth_callis totally unspecified for error cases, which is why the--noVMErrorsOnRPCResponsegot set on Ganache. Here's a summary of what is happening:eth_call, and Ganache will attempt to decode the revert reason data as a UTF-8 string to send as part of the error. There is raw "return" data,but I think it is actually just the originaland it's an ABI-encoded Error.calldataechoed back--noVMErrorsOnRPCResponseand Geth will return the data supplied torevertcall as the response. There's no distinguishing this from a regular return. Our use case depends on this behavior, as buggy as it feels to me.which is actually just the.calldataechoed back, so there isn't a way to use Parity to do a gas estimate through therequiredTxGasmethodEdit 2: Found that it's not the
calldataechoed back, but actually ABI-encodedError(string)data: https://solidity.readthedocs.io/en/latest/control-structures.html#revertThis also explains the
.substring(138)that I didn't understand.In any case, it is a matter of getting that data now.
Edit 3: works with OpenEthereum now. Tested with the following:
parity --config dev --unlock 0x00a329c0648769a73afac7f9381e08fb43dbea72 --password <(echo '')