Monorepo #143
Merged
Monorepo #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmv08
reviewed
Feb 17, 2021
tsconfig.base.json
Outdated
| @@ -8,12 +8,11 @@ | |||
| "target": "ES6", | |||
| "module": "ES2020", | |||
| "outDir": "lib/esm", | |||
| "types" : [ "node", "mocha" ], | |||
There was a problem hiding this comment.
I checked the problem we had with yarn run cpk:test and it worked for me with this option removed 🤷♂️
I don't think we need to use it, the docs don't seem to make much sense in our case
There was a problem hiding this comment.
In my case they only work with this option
There was a problem hiding this comment.
what if you reinstall node-modules by deleting the folder and lockfiles? sometimes with a mono repo it is the case
There was a problem hiding this comment.
I've already tried that and still doesn't work without it
mmv08
approved these changes
Feb 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create Contract Proxy Kit Monorepo