Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rockside transaction relay integration #135

Merged
merged 16 commits into from
Feb 10, 2021
Merged

Conversation

germartinez
Copy link
Member

No description provided.

@germartinez germartinez marked this pull request as ready for review December 8, 2020 01:36
@germartinez germartinez requested a review from cag December 21, 2020 16:35
@germartinez germartinez changed the title Rockside tranasction relay integration Rockside transaction relay integration Dec 22, 2020
@germartinez germartinez requested review from mmv08 and removed request for cag February 8, 2021 09:22
@mmv08
Copy link
Member

mmv08 commented Feb 8, 2021

should the conflicts be fixed?

}
}

export default RocksideRelayTransactionManager
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the logic for sending requests could be extracted to a util function

@germartinez germartinez merged commit 61fbd87 into development Feb 10, 2021
@germartinez germartinez deleted the rockside-relay branch February 10, 2021 13:15
@germartinez germartinez mentioned this pull request Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants