Merge pull request #41 from 5152Alotobots/depchecker

fix workflow
5152Alotobots · Dec 23, 2024 · 712c0c3 · 712c0c3
2 parents 92b0cf7 + de8dd17
commit 712c0c3
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 19 deletions.
diff --git a/.github/scripts/check_vendordeps.py b/.github/scripts/check_vendordeps.py
@@ -237,12 +237,14 @@ def main():
         if os.getenv('GITHUB_OUTPUT'):
             with open(os.environ['GITHUB_OUTPUT'], 'a') as f:
                 f.write(f"has_updates=true\n")
-                f.write(f"updates={json.dumps(updates)}\n")
+                # Properly escape the JSON string for GitHub Actions
+                updates_json = json.dumps(updates).replace('%', '%25').replace('\n', '%0A').replace('\r', '%0D')
+                f.write(f"updates={updates_json}\n")
     else:
         print("\nAll dependencies are up to date!")
         if os.getenv('GITHUB_OUTPUT'):
             with open(os.environ['GITHUB_OUTPUT'], 'a') as f:
                 f.write("has_updates=false\n")
-
+                f.write("updates=[]\n")
 if __name__ == "__main__":
     main()
diff --git a/.github/workflows/check_vendordeps.yml b/.github/workflows/check_vendordeps.yml
@@ -30,21 +30,41 @@ jobs:
         uses: actions/github-script@v6
         with:
           script: |
-            const updates = JSON.parse(process.env.UPDATES);
-            const body = updates.map(u => 
-              `### ${u.name}\n` +
-              `- Current version: ${u.current}\n` +
-              `- Latest version: ${u.latest}\n` +
-              `- Source: ${u.source}\n` +
-              (u.url ? `- [View Release](${u.url})\n` : '') +
-              (u.name === 'WPILib' ? '\n⚠️ **Note**: Please use WPILib VS Code tools for actual updates\n' : '') +
-              (u.notes ? '\n<details><summary>Release Notes</summary>\n\n' + u.notes + '\n</details>\n' : '')
-            ).join('\n');
+            try {
+              const updates = JSON.parse('${{ steps.check.outputs.updates }}');
             
-            await github.rest.issues.create({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              title: '🔄 Dependency Updates Available',
-              body: body,
-              labels: ['dependencies']
-            });
+              let body = '# Dependency Updates Available\n\n';
+            
+              for (const update of updates) {
+                body += `### ${update.name}\n`;
+                body += `- Current version: ${update.current}\n`;
+                body += `- Latest version: ${update.latest}\n`;
+                body += `- Source: ${update.source}\n`;
+            
+                if (update.url) {
+                  body += `- [View Release](${update.url})\n`;
+                }
+            
+                if (update.name === 'WPILib') {
+                  body += '\n⚠️ **Note**: Please use WPILib VS Code tools for actual updates\n';
+                  if (update.notes) {
+                    body += '\n<details><summary>Release Notes</summary>\n\n';
+                    body += update.notes;
+                    body += '\n</details>\n';
+                  }
+                }
+            
+                body += '\n';
+              }
+            
+              await github.rest.issues.create({
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                title: '🔄 Dependency Updates Available',
+                body: body,
+                labels: ['dependencies']
+              });
+            } catch (error) {
+              console.error('Error processing updates:', error);
+              core.setFailed(error.message);
+            }