perf: opt nested agg calls #4022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. nested aggregate call 2. duplicated aggregate call
Initially we only intend to cache udaf calls under same window, this change seem to cache all expressions under correct context. This cache mechanism may not work since its not fully tested.
aggregate expression A nested agg function call, e.g. agg_fn1(col1, agg_fn2(col2)) Will evaluate like a let expression: LET fn2 = agg_fn2(col2) IN agg_fn1(col1, fn2) TODO: - fix agg call cache
TOOD: - there are some cases still need fix
Shouren
pushed a commit
that referenced
this pull request
Feb 18, 2025
* perf(expr pass): cache aggregate function call in single projection * test: add two test cases for aggregate calls 1. nested aggregate call 2. duplicated aggregate call * feat(lambdafy): cache same expression Initially we only intend to cache udaf calls under same window, this change seem to cache all expressions under correct context. This cache mechanism may not work since its not fully tested. * feat(expr pass): letify expression to avoid repeated agg calls in nested aggregate expression A nested agg function call, e.g. agg_fn1(col1, agg_fn2(col2)) Will evaluate like a let expression: LET fn2 = agg_fn2(col2) IN agg_fn1(col1, fn2) TODO: - fix agg call cache * feat(expr pass): equivalent agg call cache TOOD: - there are some cases still need fix * fix: set output to id node for equivalent agg calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.