Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support external udaf function #2825

Merged
merged 31 commits into from
Mar 22, 2023
Merged

feat: support external udaf function #2825

merged 31 commits into from
Mar 22, 2023

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Nov 25, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added the execute-engine hybridse sql engine label Nov 25, 2022
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Patch coverage: 88.86% and project coverage change: -0.08 ⚠️

Comparison is base (3e7cbe5) 75.73% compared to head (926d158) 75.66%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2825      +/-   ##
============================================
- Coverage     75.73%   75.66%   -0.08%     
  Complexity      393      393              
============================================
  Files           672      669       -3     
  Lines        124836   124683     -153     
  Branches       1117     1171      +54     
============================================
- Hits          94546    94341     -205     
- Misses        30054    30122      +68     
+ Partials        236      220      -16     
Impacted Files Coverage Δ
hybridse/include/vm/engine.h 96.05% <ø> (ø)
hybridse/src/codegen/ir_base_builder.cc 68.74% <ø> (-1.26%) ⬇️
hybridse/src/node/sql_node.cc 78.84% <ø> (+0.11%) ⬆️
hybridse/src/udf/dynamic_lib_manager.h 100.00% <ø> (+32.07%) ⬆️
hybridse/src/udf/udf.h 98.43% <ø> (ø)
hybridse/src/udf/udf_library.h 100.00% <ø> (ø)
...a/com/_4paradigm/openmldb/batch/SparkPlanner.scala 59.33% <0.00%> (-0.29%) ⬇️
...aradigm/openmldb/batch/utils/ExternalUdfUtil.scala 7.69% <0.00%> (-0.31%) ⬇️
hybridse/src/vm/engine_compile_test.cc 96.99% <80.00%> (ø)
hybridse/src/udf/dynamic_lib_manager.cc 80.70% <80.70%> (ø)
... and 12 more

... and 32 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2022

SDK Test Report

  95 files    95 suites   1m 27s ⏱️
185 tests 175 ✔️ 10 💤 0
231 runs  221 ✔️ 10 💤 0

Results for commit f583a41.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2022

HybridSE Linux Test Report

19 438 tests   19 436 ✔️  8m 10s ⏱️
     244 suites           2 💤
       67 files             0

Results for commit f583a41.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2022

HybridSE Mac Test Report

19 438 tests   19 436 ✔️  9m 52s ⏱️
     244 suites           2 💤
       67 files             0

Results for commit f583a41.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2022

Linux Test Report

       56 files       230 suites   1h 14m 12s ⏱️
11 927 tests 11 920 ✔️ 7 💤 0
16 928 runs  16 921 ✔️ 7 💤 0

Results for commit 5e1a8c5.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Dec 7, 2022
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 8, 2022
@dl239 dl239 marked this pull request as ready for review December 8, 2022 01:36
@dl239
Copy link
Collaborator Author

dl239 commented Dec 8, 2022

support null value

@github-actions github-actions bot added the batch-engine openmldb batch(offline) engine label Dec 9, 2022
@dl239 dl239 requested a review from aceforeverd December 12, 2022 07:27
@dl239 dl239 requested review from lqy222 and zhanghaohit December 12, 2022 07:27
@dl239 dl239 linked an issue Dec 28, 2022 that may be closed by this pull request
@dl239 dl239 requested a review from aceforeverd March 21, 2023 11:20
@dl239 dl239 merged commit 0fcbc54 into 4paradigm:main Mar 22, 2023
@dl239 dl239 deleted the feat/udaf branch March 22, 2023 01:17
dl239 added a commit to dl239/OpenMLDB that referenced this pull request Mar 22, 2023
dl239 added a commit that referenced this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch-engine openmldb batch(offline) engine documentation Improvements or additions to documentation execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support creating aggregate function
3 participants