Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add count of rows read #1404

Closed
wants to merge 8 commits into from
Closed

feat: add count of rows read #1404

wants to merge 8 commits into from

Conversation

cswjd
Copy link
Contributor

@cswjd cswjd commented Mar 9, 2022

feat(1327): add count of rows read

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2022

Linux Test Report

   111 files     196 suites   44m 39s ⏱️
8 625 tests 8 621 ✔️ 3 💤 1
8 656 runs  8 652 ✔️ 3 💤 1

For more details on these failures, see this check.

Results for commit bc5462c.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #1404 (8e2dd1d) into main (ac8f4b9) will decrease coverage by 0.17%.
The diff coverage is n/a.

❗ Current head 8e2dd1d differs from pull request most recent head bc5462c. Consider uploading reports for the commit bc5462c to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1404      +/-   ##
============================================
- Coverage     65.67%   65.49%   -0.18%     
  Complexity      236      236              
============================================
  Files           571      571              
  Lines        107321   106952     -369     
  Branches        859      859              
============================================
- Hits          70480    70046     -434     
- Misses        36689    36754      +65     
  Partials        152      152              
Impacted Files Coverage Δ
src/sdk/result_set_sql.h 8.86% <0.00%> (-43.04%) ⬇️
src/sdk/result_set_sql.cc 25.00% <0.00%> (-27.39%) ⬇️
src/cmd/sql_cmd.h 8.84% <0.00%> (-12.39%) ⬇️
src/sdk/db_sdk.h 74.07% <0.00%> (-7.29%) ⬇️
src/catalog/tablet_catalog.h 42.50% <0.00%> (-6.39%) ⬇️
hybridse/include/vm/catalog.h 41.96% <0.00%> (-4.01%) ⬇️
src/sdk/mini_cluster.h 76.74% <0.00%> (-3.13%) ⬇️
src/sdk/sql_cluster_router.cc 38.48% <0.00%> (-2.95%) ⬇️
src/schema/schema_adapter.cc 38.40% <0.00%> (-2.43%) ⬇️
src/sdk/db_sdk.cc 62.42% <0.00%> (-1.82%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac8f4b9...bc5462c. Read the comment docs.

@lumianph
Copy link
Collaborator

lumianph commented Mar 10, 2022

feat(1327): add count of rows read

@l-y-l Hello, we really appreciate your contribution to the issue. However, as the other contributor has submitted the PR earlier (#1401 ), we will merge that PR. But no worry, you will still have our contribution reward. So please still send an email to contact@openmldb.ai , and quote this PR.

Moreover, we strongly encourage you to further take a look at other good-first-issues. We are looking forward to see your PR again. Thanks!

@vagetablechicken vagetablechicken changed the title feat(1327): add count of rows read feat: add count of rows read Mar 11, 2022
@cswjd cswjd closed this Mar 11, 2022
@cswjd cswjd deleted the branch1 branch March 11, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants