Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bugfix of failed to register notebook magic with python SDK #1314

Merged
merged 1 commit into from
Feb 25, 2022
Merged

fix: bugfix of failed to register notebook magic with python SDK #1314

merged 1 commit into from
Feb 25, 2022

Conversation

HuilinWu2
Copy link
Collaborator

see issue #1309

@HuilinWu2 HuilinWu2 added the bug Something isn't working label Feb 25, 2022
@HuilinWu2 HuilinWu2 linked an issue Feb 25, 2022 that may be closed by this pull request
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested in MacOS.

@tobegit3hub tobegit3hub added this to the v0.5 milestone Feb 25, 2022
@github-actions
Copy link
Contributor

Linux Test Report

     104 files       230 suites   42m 27s ⏱️
  8 613 tests   8 610 ✔️ 3 💤 0
12 740 runs  12 737 ✔️ 3 💤 0

Results for commit 2f8f771.

@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #1314 (2f8f771) into main (aaf9803) will decrease coverage by 0.00%.
The diff coverage is 62.96%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1314      +/-   ##
============================================
- Coverage     65.53%   65.53%   -0.01%     
  Complexity      222      222              
============================================
  Files           570      570              
  Lines        106449   106494      +45     
  Branches        855      857       +2     
============================================
+ Hits          69766    69790      +24     
- Misses        36537    36558      +21     
  Partials        146      146              
Impacted Files Coverage Δ
...4paradigm/openmldb/batch/nodes/WindowAggPlan.scala 73.86% <ø> (-0.03%) ⬇️
...openmldb/taskmanager/config/TaskManagerConfig.java 0.00% <0.00%> (ø)
...a/com/_4paradigm/openmldb/batch/SparkPlanner.scala 63.68% <33.33%> (-0.52%) ⬇️
..._4paradigm/openmldb/batch/utils/HybridseUtil.scala 60.90% <38.46%> (-2.44%) ⬇️
..._4paradigm/openmldb/batch/utils/SparkRowUtil.scala 58.53% <59.09%> (-3.37%) ⬇️
hybridse/src/codec/fe_row_codec.cc 76.57% <100.00%> (+0.07%) ⬆️
...4paradigm/openmldb/batch/OpenmldbBatchConfig.scala 85.36% <100.00%> (+0.36%) ⬆️
...4paradigm/openmldb/batch/api/OpenmldbSession.scala 57.57% <100.00%> (+4.76%) ⬆️
...paradigm/openmldb/batch/nodes/SelectIntoPlan.scala 60.00% <0.00%> (-13.34%) ⬇️
..._4paradigm/openmldb/batch/nodes/LoadDataPlan.scala 53.68% <0.00%> (-2.11%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e7fb76...2f8f771. Read the comment docs.

@tobegit3hub tobegit3hub merged commit 1aecdbc into 4paradigm:main Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to register notebook magic function with Python SDK
3 participants