Attempt to remove modal window frame to hide close button on linux #4252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,6 +36,10 @@ const loadModalWindow = ({ | |||
| backgroundColor, | |||
| modal: true, | |||
| center: true, | |||
| // Hide top bar to hide close button (needed on Linux) so that | |||
| // one cannot close the modal window without using Save or Cancel | |||
| // buttons (and lose work on Piskel for instance) (Workaround for #4245). | |||
There was a problem hiding this comment.
The ModalWindow is also used for yarn and jfxr.
Are we sure this removal of the top bar doesn't affect them?
There was a problem hiding this comment.
It will affect them and for the same logic: we don't want to exit those modal windows without using the Save or Cancel buttons
There was a problem hiding this comment.
If we're happy it doesn't prevent closing the window on all 3 tools, then ok 👍
4ian
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #4245.
Not sure it will work (not using Linux) so we'll wait for next release.