Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix isActive on query #94

Merged
merged 1 commit into from
Jun 19, 2017
Merged

fix isActive on query #94

merged 1 commit into from
Jun 19, 2017

Conversation

jquense
Copy link
Member

@jquense jquense commented Jun 12, 2017

No description provided.

@taion
Copy link
Contributor

taion commented Jun 12, 2017

Let's do something like

isEqual(matchQuery[key], value) ||
(value === undefined && !Object.prototype.hasOwnProperty.call(matchQuery, key))

@taion
Copy link
Contributor

taion commented Jun 12, 2017

Did this just not handle the special logic I added to RR for using undefined to mean "this query arg must be empty"?

@jquense
Copy link
Member Author

jquense commented Jun 12, 2017

Did this just not handle the special logic I added to RR for using undefined to mean "this query arg must be empty"?

I think so yeah.

@taion
Copy link
Contributor

taion commented Jun 12, 2017

oops we should support that

@taion
Copy link
Contributor

taion commented Jun 16, 2017

could you fix that real quick?

@jquense
Copy link
Member Author

jquense commented Jun 17, 2017

Sorry :P I'll get it in a bit

@taion taion force-pushed the fix-query-active branch from 6189fdf to 816a911 Compare June 19, 2017 17:47
@taion taion merged commit 93959b6 into master Jun 19, 2017
@taion taion deleted the fix-query-active branch June 19, 2017 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jquense @taion