Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an explicit warning if the path-to-regexp version is wrong #92

Merged
merged 1 commit into from
Jun 8, 2017

Conversation

taion
Copy link
Contributor

@taion taion commented Jun 8, 2017

No description provided.

@taion taion force-pushed the path-to-regexp-warn branch from f3a52d8 to 280b427 Compare June 8, 2017 21:30
warning(
typeof pathToRegexp.compile === 'function',
'Incorrect version of path-to-regexp imported. If this is running ' +
'from a client bundle, check your bundler settings.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I've hit this before

@taion taion merged commit 8a6bac8 into master Jun 8, 2017
@taion taion deleted the path-to-regexp-warn branch June 8, 2017 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants