refactor: Drop componentWillReceiveProps #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
taion
commented
Mar 29, 2019
| @@ -84,19 +93,26 @@ export default function createBaseRouter({ | |||
| } | |||
| } | |||
|
|
|||
| componentWillReceiveProps(nextProps) { | |||
| static getDerivedStateFromProps({ match, resolver, matchContext }, state) { | |||
There was a problem hiding this comment.
this shouldn't run on the initial render
jquense
reviewed
Mar 30, 2019
| resolver, | ||
| matchContext, | ||
| iteration: state.iteration + 1, | ||
| }; |
There was a problem hiding this comment.
you could use getSnapshotBeforeUpdate() and cheat a bit since it is an instance method: return this.shouldResolveMatch = true
There was a problem hiding this comment.
i need to update stuff before render, though, so this.lastIteration === iteration evaluates as false in render and prevents the unnecessary update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #171