This repository has been archived by the owner on Apr 22, 2020. It is now read-only.
Bump cats to 1.0.0-MF #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -185,7 +185,6 @@ object libraries { | |||
| "cats-kernel" -> (("org.typelevel", "cats-kernel", v("cats"))), | |||
| "cats-laws" -> (("org.typelevel", "cats-laws", v("cats"))), | |||
| "cats-macros" -> (("org.typelevel", "cats-macros", v("cats"))), | |||
| "cats" -> (("org.typelevel", "cats", v("cats"))), | |||
There was a problem hiding this comment.
We could leave this key in the Map, just for legacy reasons, pointing to the cats-core dependency, what do you think?
- "cats" -> (("org.typelevel", "cats", v("cats"))),
+ "cats" -> (("org.typelevel", "cats-core", v("cats"))),There was a problem hiding this comment.
The problem is that the cats artifact used to contain:
cats-corecats-macroscats-freesimulacrummachinist
Are we okay with reducing that to only cats-core?
There was a problem hiding this comment.
Yeah, that's something users might not expect either. Let's remove it then, users will need to specify the new dependencies accordingly.
juanpedromoreno
approved these changes
Sep 21, 2017
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My bad, I forgot I had specified the cats version in the github4s build