-
Notifications
You must be signed in to change notification settings - Fork 6
Removes SBT dependency from core module #633
Conversation
2555468
to
40d4955
Compare
40d4955
to
c595b28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, however, I've added some comments.
Thanks!
@@ -53,7 +53,7 @@ package object io { | |||
|
|||
def toPath: Path = get(filename) | |||
|
|||
def toFile: File = file(filename.fixPath) | |||
def toFile: File = new File(filename.fixPath) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IO.file
to be consistent?
|
||
object IO { | ||
|
||
def file(path: String): File = new File(path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IO.file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inception?
writer.close() | ||
} | ||
|
||
def relativize(base: File, file: File): Option[String] = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review. We need to avoid the use of |
This PR removes the SBT dependency from the core module. The biggest change is that the runnable classes are moved from the core to the plugin, so it can lead some incompatibility issues.