Skip to content
This repository has been archived by the owner on Apr 22, 2020. It is now read-only.

Unifies FileType and validation types #252

Merged
merged 3 commits into from
Apr 24, 2017

Conversation

fedefernandez
Copy link
Contributor

Fixes #221

Please, @juanpedromoreno could you review? Thanks

@fedefernandez fedefernandez changed the title Unifies filetye and validation types Unifies FileType and validation types Apr 24, 2017
@fedefernandez fedefernandez force-pushed the ff-issue-221-unify-filetype-and-validation branch from e55fd8e to d18ac75 Compare April 24, 2017 15:46
@fedefernandez fedefernandez force-pushed the ff-issue-221-unify-filetype-and-validation branch from d18ac75 to e670efd Compare April 24, 2017 15:48
Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
giphy 11

@fedefernandez
Copy link
Contributor Author

@juanpedromoreno fixed tests and set the next release version, please, could you have a second look? Thanks

Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fedefernandez fedefernandez merged commit f3c6063 into master Apr 24, 2017
@fedefernandez fedefernandez deleted the ff-issue-221-unify-filetype-and-validation branch April 24, 2017 17:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants