This repository has been archived by the owner on Apr 22, 2020. It is now read-only.
Fixes commit files method #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscodr
approved these changes
Mar 18, 2020
BenFradet
approved these changes
Mar 18, 2020
| @@ -79,7 +79,7 @@ class GitHubOps[F[_]: ConcurrentEffect: Timer]( | |||
| path <- EitherT.right(Sync[F].delay(file.getAbsolutePath())) | |||
| content <- EitherT(Sync[F].delay(fileReader.getFileContent(path))) | |||
| relativePath <- EitherT.right(relativePath(file)) | |||
| } yield (content, relativePath) | |||
| } yield (relativePath, content) | |||
There was a problem hiding this comment.
Haha, no worries, the real error is to have the (String, String) as response
juanpedromoreno
approved these changes
Mar 18, 2020
calvellido
approved these changes
Mar 19, 2020
|
Thanks @franciscodr |
|
Sorry, I just noticed it, should this also be updated to |
|
@calvellido probably? Let's make a release with that updated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this issue in the sbt-hood and sbt-microsites releases. Concretely there are a couple of issues: