-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scrimage to 4.x from 2.x & fix copying resources #529
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Currently working with the scripted tests, as these are failing now. The new copying resources code isn't quite matching up and I've got a lead on where to fix it at least. Hold off on reviewing for now. |
The build is "fixed" in terms of, if you pull this branch locally and run |
Scrimage, a dependency of sbt-microsites, has actually been significantly out of date for some time, probably due to a dependency name change from
scrimage-core
toscrimage-scala
for the Scala-specific dependencies. This updates the library, and replaces the one usage of it using the latest syntax.EDIT: The scope of this has expanded slightly to also fixing the build, by rewriting the
copyJARResourcesTo
function (nowcopyResourcesFromFileSystem
) to work with arbitrary filesystems. While I'm not entirely sure what the cause of the build issues was, this issue might have had something to do with the specific JDK I am using (adoptopenjdk 8) as the issue was nonexistent before, and only popped up recently in the build.