Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix distorted 2x jumbotron pattern #484

Merged
merged 1 commit into from
May 11, 2020
Merged

Fix distorted 2x jumbotron pattern #484

merged 1 commit into from
May 11, 2020

Conversation

slice
Copy link
Contributor

@slice slice commented May 8, 2020

Despite the documentation saying that there isn't a size requirement for jumbotron patterns, it gets squished down to a fixed size on high density displays. This seems unintentional.

Fix it by changing the fixed size values to auto, which just uses the image size.

Bug in action on https://typelevel.org/cats:

image

Fixed:

image

@calvellido calvellido self-requested a review May 11, 2020 07:58
calvellido
calvellido approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@calvellido calvellido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@calvellido
Copy link
Contributor

Great, many thanks for fixing this @slice!

@calvellido calvellido merged commit f657eb3 into 47degrees:master May 11, 2020
@juanpedromoreno juanpedromoreno added the bug Something isn't working label May 11, 2020
@slice slice deleted the fix-2x-jumbotron-pattern branch May 13, 2020 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvellido calvellido calvellido approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slice @calvellido @juanpedromoreno