Removes Sbt-org-policies Dependency #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanpedromoreno
added
the
breaking-change
BenFradet
approved these changes
Apr 9, 2020
franciscodr
reviewed
Apr 9, 2020
|
Also, I'm thinking there might be an existing library to perform all this file I/O? |
Co-Authored-By: Ben Fradet <benjamin.fradet@gmail.com>
…icrosites into removes-sbt-org-policies
Yeah, that would make sense, and I'm sure it exists something. However, I didn't want to make this PR too complicated needed to migrate the existing code in sbt-microsites to the potential new library. |
|
yes definitely, it was more a general remark than one specific to this PR 👍 |
franciscodr
approved these changes
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Github actions workflows are now providing what the sbt plugin was doing until now.
It also:
plugins.sbtlevel. We have now someSBTduplicated code, but hopefully, @scala-steward will take care of the dependencies.Exceptions,Config.scala,GitHubOps.scala,FileReader.scala,FileWriter.scala,IOUtils.scala, andYamlFormats.scala.GitHubOpsalgebra, apart from copying-paste, I've simplified it removing all theEitherTtypes, apart from upgrading to the latest version of github4s. Original version 🔗 .Note: the microsite step will fail once this is merged in master, but that's expected (the solution is still in progress).