Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded sbt version from Travis config #428

Merged
merged 2 commits into from
Feb 20, 2020

Conversation

calvellido
Copy link
Contributor

I feel like this could be the culprit as to why the current 1.1.1 version has not been published, but I'm not totally sure, as some parts of the workflow has been completed but others don't:

https://repo1.maven.org/maven2/com/47deg/sbt-microsites_2.12_1.0/

🤔

* Remove hardcoded sbt version from Travis config
Copy link
Contributor

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The matrix can be removed entirely, no? since there is only one run

@juanpedromoreno
Copy link
Member

That's probably due to the latest version of sbt-org-policies bringing in an upgraded version of sbt-pgp which is requiring some changes in the projects using it. I think @cb372 is working on a fix.

* Remove matrix param
@calvellido
Copy link
Contributor Author

Uhmmm, right.

I still feel like these changes are valid, do you agree?

As suggested by @BenFradet, I also removed the matrix setting.

Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mr @calvellido

@calvellido calvellido merged commit 4def405 into master Feb 20, 2020
@calvellido calvellido deleted the jv-travis-sbt-version branch February 20, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants