Remove default GitHub repo values #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvellido
requested review from
gutiory,
juanpedromoreno and
AntonioMateoGomez
AntonioMateoGomez
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the memeid microsite, @gutiory faced an issue where the
sbt-micrositesplugin might rewrite thesbt-micrositesown microsite if nomicrositeGithubOwnerandmicrositeGithubRepoare defined in the project using the plugin.This is due to a combination of factors: the GitHub repo and owner default values,
micrositePushSiteWithdefault setting, and the fact that the user executing had permission to write on thesbt-micrositesrepositorygh-branch.To overcome this (uncommon though) situation, this PR sets the default GitHub owner and repo values to empty lines.