-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New style redesign #354
New style redesign #354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to specify that Jekyll 4.0.0 at least is required to be installed on the system
Good Job @AntonioMateoGomez , I add some comments:
|
…icrosites into paolo-334-new-style-redesign
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the page
layout:
https://47deg.github.io/sbt-microsites/docs/layouts.html#page-layout-and-menu-partial-layout
We need to:
-
Either specify that the
page
layout is not supported for the new defaultlight
theme. Also, this will be important to remark in any version release announcement, as it could break sites like Scalaz, Cats, or fs2 ones. -
Either support this layout on the new default theme. Maybe we can even simply make a quick translation of the new home including the horizontal navbar.
Thoughts on this @juanpedromoreno, @AntonioMateoGomez, @israelperezglez? If we had to vote I'd try to go with the latter option 🙂
…icrosites into paolo-334-new-style-redesign
s"View on ${config.gitSettings.gitHostingService.name}") | ||
) | ||
), | ||
"{% include menu.html %}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes all light
Home
layouts include a menu when they shoudln't 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR implements the new Sbt-microsites design wich we have named
light
. We also keep the classicpattern
style and we provide the option to generate it aswell.Documentation has change to describe how to set any of these two styles.
We remove
bootstrap
from the new style, also we change the default highlight theme asatelier-forest-light
.We are still not changing the
version.sbt
file to do it in a next PR to launch the next release, once done so, we must to change theplugins.sbt
file so sbt-microsites will display the newlight
style.Fixes #334