Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#267 documentation label configurable #268

Merged

Conversation

Obarros
Copy link
Contributor

@Obarros Obarros commented Jun 18, 2018

Fix #267!

Ping @calvellido Take a look when you have time.
Thanks again for the support.

TODO:

  • Validate with a test case?
  • Update docs?
  • Get feedback on the changes?
  • Run, the Scalafmt configuration to ensure everything is formatted?

@calvellido calvellido self-requested a review June 19, 2018 07:00
Copy link
Contributor

@calvellido calvellido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👌

@calvellido
Copy link
Contributor

Just added a bit more documentation on the settings page, but besides that, everything is great.

@calvellido calvellido merged commit a7b51de into 47degrees:master Jun 19, 2018
calvellido added a commit that referenced this pull request Jun 19, 2018
Make Documentation label configurable (#268)
@Obarros Obarros deleted the #267-documentation-label-configurable branch June 20, 2018 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants