User configurable footer #220
Conversation
| test("globalFooter TypeTag should have the appropriate content") { | ||
|
|
||
| val property = forAll { implicit settings: MicrositeSettings ⇒ | ||
| (settings.templateTexts.footer.isDefined) ==> { |
There was a problem hiding this comment.
Is there a ligature for ==>?
There was a problem hiding this comment.
Not that I'm aware of but AFAIK we don't use special symbols anywhere since many fonts already display ligatures for those
There was a problem hiding this comment.
Only reason I ask is this project has ⇒ explicitly on Line 84 and 47deg/fetch has scalafmt rewrite rules to remove them(https://github.com/47deg/fetch/blob/master/.scalafmt.conf#L24). I was curious if we are requiring/maintaining consistency.
| @@ -133,6 +133,10 @@ trait MicrositeKeys { | |||
| "Optional. Add custom Gitter sidecar Chat URL. By default is owner/repository." | |||
| ) | |||
|
|
|||
| val micrositeFooterText: SettingKey[Option[String]] = SettingKey[Option[String]]( | |||
There was a problem hiding this comment.
Would this make more sense as Option[TypedTag[String]] for more type safety?
There was a problem hiding this comment.
you mean as as scalatags tag? I think is fine like that but if scalatags types make sense here then sure.
There was a problem hiding this comment.
Yup, scalatags. My only apprehension is would the user need to add another dependency? Or does the scalatags dependency come for "free" when a user adds sbt-microsites?
The current String allows one to always {blah: TypedTag[String]}.toString.
| @@ -133,6 +133,10 @@ trait MicrositeKeys { | |||
| "Optional. Add custom Gitter sidecar Chat URL. By default is owner/repository." | |||
| ) | |||
|
|
|||
| val micrositeFooterText: SettingKey[Option[String]] = SettingKey[Option[String]]( | |||
There was a problem hiding this comment.
you mean as as scalatags tag? I think is fine like that but if scalatags types make sense here then sure.
| test("globalFooter TypeTag should have the appropriate content") { | ||
|
|
||
| val property = forAll { implicit settings: MicrositeSettings ⇒ | ||
| (settings.templateTexts.footer.isDefined) ==> { |
There was a problem hiding this comment.
Not that I'm aware of but AFAIK we don't use special symbols anywhere since many fonts already display ligatures for those
|
@suhasgaddam @juanpedromoreno when the release is ready can you let @kailuowang and @BennyHill know? They were the ones that originally requested this to be configurable for cats. |
|
It looks like @dominv bumped @BennyHill @kailuowang For documentation on the setting: https://github.com/47deg/sbt-microsites/blob/master/docs/src/main/tut/docs/settings.md |
|
thanks very much! |
Closes #218
I'm not completely fond of
micrositeFooterTextas a setting key name because there are 2 lines in the footer. This setting only allows modifying the second the second line.