-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gitter Link Settings #197
Gitter Link Settings #197
Conversation
create docs for some setting
…atags # Conflicts: # src/main/scala/microsites/MicrositeKeys.scala
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, @juanpedromoreno can you also take a look at this? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, however I've request a minor change. Thanks!
@@ -98,6 +98,7 @@ object MicrositesPlugin extends AutoPlugin { | |||
micrositePushSiteWith := GHPagesPlugin, | |||
micrositeAnalyticsToken := "", | |||
micrositeGitterChannel := true, | |||
micrositeGitterChannelUrl := "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could set the default value here, based on owner/repo.
|room: '${config.gitSettings.githubOwner}/${config.gitSettings.githubRepo}'};""".stripMargin), | ||
script(src := s"https://sidecar.gitter.im/dist/sidecar.v1.js") | ||
) | ||
val gitSidecar: List[TypedTag[String]] = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressing the comment above, we wouldn't need to add any special logic here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #195 Create a setting to custom Gitter channel