-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes metatags and solarized-dark issues #187
Conversation
create docs for some setting
docs/src/main/tut/docs/settings.md
Outdated
|
||
``` | ||
micrositeOrganizationHomepage := "http://www.47deg.com" | ||
``` | ||
|
||
- `micrositeTwitter`: this setting is used for the Twitter integration. This generate a meta that Twitter use in his [Twitter Cards](https://cards-dev.twitter.com/validator). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-This generate a meta that Twitter use in his
+This generates a meta that Twitter uses in its
docs/src/main/tut/docs/settings.md
Outdated
micrositeTwitter := @sbt-microsites | ||
``` | ||
|
||
- `micrositeTwitterCreator`: this particular setting is used for the Twitter integration. This generate a meta that Twitter use in his [Twitter Cards](https://cards-dev.twitter.com/validator). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
val micrositeOrganizationHomepage: SettingKey[String] = | ||
settingKey[String]("Microsite organisation homepage") | ||
val micrositeTwitter: SettingKey[String] = settingKey[String]("Microsite twitter") | ||
val micrositeTwitterCreator: SettingKey[String] = settingKey[String]("Microsite twitter") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Microsite Twitter Creator"
val micrositeHomepage: SettingKey[String] = settingKey[String]("Microsite homepage") | ||
val micrositeOrganizationHomepage: SettingKey[String] = | ||
settingKey[String]("Microsite organisation homepage") | ||
val micrositeTwitter: SettingKey[String] = settingKey[String]("Microsite twitter") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Microsite Twitter"
@@ -97,6 +97,6 @@ class HomeLayout(config: MicrositeSettings) extends Layout(config) { | |||
) | |||
|
|||
def scriptsKazari: List[TypedTag[String]] = | |||
scripts ++ List(script(src := "{{ site.baseurl }}/js/kazari.js"), script(kazariEnableScript)) | |||
scripts ++ List(script(src := "{{ site.baseurl }}/js/kazari.js"), kazariEnableScript) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
) ++ ganalytics.toList | ||
href := "{{site.url}}{{site.baseurl}}/img/favicon.png"), | ||
meta(name := "twitter:title", content := config.identity.name), | ||
meta(name := "twitter:image", content := s"${config.identity.homepage}img/poster.png"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should check here we have the slash at the end (there is a helper to check it)
docs/src/main/tut/docs/settings.md
Outdated
@@ -68,13 +68,13 @@ micrositeHomepage := "https://47deg.github.io/sbt-microsites/" | |||
micrositeOrganizationHomepage := "http://www.47deg.com" | |||
``` | |||
|
|||
- `micrositeTwitter`: this setting is used for the Twitter integration. This generate a meta that Twitter use in his [Twitter Cards](https://cards-dev.twitter.com/validator). | |||
- `micrositeTwitter`: this setting is used for the Twitter integration. This generate a meta that Twitter use in its [Twitter Cards](https://cards-dev.twitter.com/validator). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still This generate
instead of This generates
AND
Twitter use
instead of Twitter uses
docs/src/main/tut/docs/settings.md
Outdated
|
||
``` | ||
micrositeTwitter := @sbt-microsites | ||
``` | ||
|
||
- `micrositeTwitterCreator`: this particular setting is used for the Twitter integration. This generate a meta that Twitter use in his [Twitter Cards](https://cards-dev.twitter.com/validator). | ||
- `micrositeTwitterCreator`: this particular setting is used for the Twitter integration. This generate a meta that Twitter use in its [Twitter Cards](https://cards-dev.twitter.com/validator). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
@@ -134,6 +134,11 @@ trait MicrositeAutoImportSettings extends MicrositeKeys { | |||
s"/${micrositeBaseUrl.value}" | |||
else micrositeBaseUrl.value | |||
|
|||
val homepage = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed, as I mentioned before, there is a helper method to cover it.
See this example
docs/src/main/tut/docs/settings.md
Outdated
- `micrositeTwitter`: this setting is used for the Twitter integration. This generates a meta that Twitter uses in its [Twitter Cards](https://cards-dev.twitter.com/validator). | ||
|
||
``` | ||
micrositeTwitter := @sbt-microsites |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realized micrositeTwitter
is expecting a string => "@sbt-microsites"
docs/src/main/tut/docs/settings.md
Outdated
- `micrositeTwitterCreator`: this particular setting is used for the Twitter integration. This generates a meta that Twitter uses in its [Twitter Cards](https://cards-dev.twitter.com/validator). | ||
|
||
``` | ||
micrositeTwitterCreator := @47deg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add meta tag and doc for Twitter creator
Fix Twitter image meta tag for Twitter card
Add Twitter and homepage settings docs
Fixes #156 and #179