Add Google Analytics settings #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanpedromoreno
requested changes
Apr 24, 2017
project/ProjectPlugin.scala
Outdated
| @@ -65,7 +65,9 @@ object ProjectPlugin extends AutoPlugin { | |||
| micrositeGithubOwner := "47deg", | |||
| micrositeGithubRepo := "sbt-microsites", | |||
| micrositeHighlightTheme := "color-brewer", | |||
| includeFilter in makeSite := "*.html" | "*.css" | "*.png" | "*.jpg" | "*.gif" | "*.js" | "*.swf" | "*.md" | |||
| includeFilter in makeSite := "*.html" | "*.css" | "*.png" | "*.jpg" | "*.gif" | "*.js" | | |||
There was a problem hiding this comment.
I think we can keep this in a single line
| @@ -115,6 +115,8 @@ trait MicrositeKeys { | |||
| "Determines what will be chosen for pushing the site. The options are sbt-ghpages plugin and github4s library.") | |||
|
|
|||
| val publishMicrositeCommandKey: String = "publishMicrosite" | |||
| val micrositeAnalyticsToken = settingKey[String]( | |||
| "In the case where your project isn't hosted on Github, use this setting to point users to git host (e.g. 'https://internal.gitlab.com/<user>/<project>').") | |||
There was a problem hiding this comment.
The description is not correct
| |})(window,document,'script','https://www.google-analytics.com/analytics.js','ga'); | ||
| | | ||
| |ga('create', '${config.identity.analytics}' , 'auto'); | ||
| |ga('send', 'pageview'); |
There was a problem hiding this comment.
Format is weird in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #157 Add Google Analytics to microsite settings