Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Port plugin to sbt {1.0.x, 0.13.16} #30

Merged
merged 2 commits into from
Sep 12, 2017
Merged

Conversation

suhasgaddam
Copy link
Contributor

@suhasgaddam suhasgaddam commented Sep 6, 2017

This requires coordination with 47degrees/sbt-org-policies#510 and 47degrees/sbt-microsites#221.

.travis.yml Outdated
after_success:
- sbt orgAfterCISuccess
- sbt ^^$SBT_VERSION orgAfterCISuccess
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking more about the eventual publishMicrosite, it should only happen one of the sbt builds.
And also bumping version.sbt/whatever commits travis does after a merge to master.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree. We could use a similar approach like the one we've used with the different Scala versions:
https://github.com/47deg/sbt-org-policies/blob/master/core/src/main/scala/sbtorgpolicies/runnable/model.scala#L25

Copy link
Contributor

@fedefernandez fedefernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

.travis.yml Outdated
after_success:
- sbt orgAfterCISuccess
- sbt ^^$SBT_VERSION orgAfterCISuccess
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree. We could use a similar approach like the one we've used with the different Scala versions:
https://github.com/47deg/sbt-org-policies/blob/master/core/src/main/scala/sbtorgpolicies/runnable/model.scala#L25

@suhasgaddam
Copy link
Contributor Author

@fedefernandez can you give this another check? a023e1e

I need to run orgUpdateDocFiles and depUpdateDependencyIssues, but they need to be guarded so they only run for 1 sbt version.

release currently publishes for both sbt versions.

I also bumped to 0.2.0-SNAPSHOT similar to how sbt-org-policies had the minor version bumped.

Copy link
Contributor

@fedefernandez fedefernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes looks good to me 👍 thanks

@suhasgaddam suhasgaddam merged commit dd455cc into master Sep 12, 2017
@suhasgaddam suhasgaddam deleted the sg-port-to-sbt-1.0.x branch September 12, 2017 22:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants