-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
.travis.yml
Outdated
after_success: | ||
- sbt orgAfterCISuccess | ||
- sbt ^^$SBT_VERSION orgAfterCISuccess |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking more about the eventual publishMicrosite
, it should only happen one of the sbt builds.
And also bumping version.sbt
/whatever commits travis does after a merge to master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree. We could use a similar approach like the one we've used with the different Scala versions:
https://github.com/47deg/sbt-org-policies/blob/master/core/src/main/scala/sbtorgpolicies/runnable/model.scala#L25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
.travis.yml
Outdated
after_success: | ||
- sbt orgAfterCISuccess | ||
- sbt ^^$SBT_VERSION orgAfterCISuccess |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree. We could use a similar approach like the one we've used with the different Scala versions:
https://github.com/47deg/sbt-org-policies/blob/master/core/src/main/scala/sbtorgpolicies/runnable/model.scala#L25
Run scalafmt.
@fedefernandez can you give this another check? a023e1e I need to run
I also bumped to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New changes looks good to me 👍 thanks
This requires coordination with 47degrees/sbt-org-policies#510 and 47degrees/sbt-microsites#221.