fix: remove dead code for index nested start keys #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This did actually occur to me too, however the current parser would accept something like |
|
I suspect we could change it without a breaking version since I didn't intentionally support the invalid syntax So if it seems sensible, I'm happy with it too I'll add a test for those cases at least though |
When using index nesting, the parse loop visits `[` and computes keys _only if_ we didn't just pass a `]`. This is to capture the start of such a key. For example, `foo[bar][baz]` would result in the only occurrence of this being `foo[`. Since a syntactically valid indexed key should only have one of these (at the start), `lastKey` should always be `undefined` at that point. So we can remove the check.
43081j
added a commit
that referenced
this pull request
Jun 23, 2024
When using index nesting, the parse loop visits `[` and computes keys _only if_ we didn't just pass a `]`. This is to capture the start of such a key. For example, `foo[bar][baz]` would result in the only occurrence of this being `foo[`. Since a syntactically valid indexed key should only have one of these (at the start), `lastKey` should always be `undefined` at that point. So we can remove the check.
43081j
added a commit
that referenced
this pull request
Jun 23, 2024
When using index nesting, the parse loop visits `[` and computes keys _only if_ we didn't just pass a `]`. This is to capture the start of such a key. For example, `foo[bar][baz]` would result in the only occurrence of this being `foo[`. Since a syntactically valid indexed key should only have one of these (at the start), `lastKey` should always be `undefined` at that point. So we can remove the check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using index nesting, the parse loop visits
[and computes keys only if we didn't just pass a].This is to capture the start of such a key. For example,
foo[bar][baz]would result in the only occurrence of this beingfoo[.Since a syntactically valid indexed key should only have one of these (at the start),
lastKeyshould always beundefinedat that point. So we can remove the check.cc @PondWader just one i noticed after merging. if you get a spare 5 mins, could you check i'm making sense here 👀