CI fixes and improvements #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `algo` parameter for the `unparam` linter has been removed and we should thus no longer specify it. Also, bumping the GolangCI-lint version to the latest available minor release. See: mvdan/unparam@e6a6d1c
Helcaraxan
force-pushed
the
update-lint-config
branch
4 times, most recently
from
c3220f6 to
31fb03c
Compare
Helcaraxan
force-pushed
the
update-lint-config
branch
from
31fb03c to
01734b1
Compare
Helcaraxan
changed the title
|
looking good, thanks! |
zeridon
pushed a commit
to zeridon/matterbridge
that referenced
this pull request
Feb 12, 2020
* Update GolangCI-lint and lint config The `algo` parameter for the `unparam` linter has been removed and we should thus no longer specify it. Also, bumping the GolangCI-lint version to the latest available minor release. See: mvdan/unparam@e6a6d1c * Fix and improve bintray CI script * Further CI setup improvements * Split-out CI steps into stand-alone scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple small pieces in this PR:
algoparameter for theunparamlinter has been removed and weshould thus no longer specify it in our
.golangci.yaml. Also, bumping the GolangCI-lintversion to the latest available minor release.
See: