Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Button): childrenがnumberのときも構造上テキストとして扱うよう修正 #1410

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

Qs-F
Copy link
Collaborator

@Qs-F Qs-F commented Jul 21, 2023

チケット

実装内容

  • Buttonの中で構造を判定するのに使っている extractText がchildrenがnumberのときに無視していたのを修正

スクリーンショット

わかりにくいですがtextのときのpaddingが左右に広めに取られるようになっているのを確認しました

変更前 変更後

相談内容(あれば)

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2023

🦋 Changeset detected

Latest commit: 19a6e85

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@4design/for-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 21, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 19a6e85
Status: ✅  Deploy successful!
Preview URL: https://7d64101f.for-ui.pages.dev
Branch Preview URL: https://fix-button-structure-childre.for-ui.pages.dev

View logs

@Qs-F Qs-F marked this pull request as ready for review July 21, 2023 07:24
@Qs-F Qs-F requested a review from locona July 21, 2023 07:24
Copy link
Contributor

@locona locona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Qs-F Qs-F merged commit bd6ee4f into main Jul 24, 2023
@Qs-F Qs-F deleted the fix/button-structure-children-number@1405 branch July 24, 2023 01:56
@github-actions github-actions bot mentioned this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button: childrenがnumberのときもtext判定にする
2 participants