Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Select): 選択項目をリセットする手段を追加 #1403

Merged
merged 9 commits into from
Jul 24, 2023

Conversation

Qs-F
Copy link
Collaborator

@Qs-F Qs-F commented Jul 19, 2023

チケット

実装内容

  • Select: clearable propを指定した際に入力値をリセットできるボタンを表示する
    • singleの場合はデフォルトでfalseで、clearable をセットすると表示されます
    • multipleの場合はデフォルトでtrueで、clearable={false} をセットすると非表示になります

スクリーンショット

変更前 変更後
なし image

相談内容(あれば)

  • a11y的観点で、buttonにフォーカスが当たらない問題があります。MUIとの根深い問題があり解決に時間がかかるので、タスクに積んでおき後日解決します。

@changeset-bot
Copy link

changeset-bot bot commented Jul 19, 2023

🦋 Changeset detected

Latest commit: 21378d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@4design/for-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 19, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 21378d2
Status: ✅  Deploy successful!
Preview URL: https://a2002db9.for-ui.pages.dev
Branch Preview URL: https://feat-select-reset-1288.for-ui.pages.dev

View logs

@Qs-F Qs-F changed the title Feat/select reset@1288 feat(Select): 選択項目をリセットする手段を追加 Jul 19, 2023
@Qs-F Qs-F marked this pull request as ready for review July 19, 2023 13:43
@Qs-F Qs-F requested a review from locona July 19, 2023 13:43
Copy link
Contributor

@locona locona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Qs-F Qs-F merged commit 71cf58f into main Jul 24, 2023
@Qs-F Qs-F deleted the feat/select-reset@1288 branch July 24, 2023 01:55
@github-actions github-actions bot mentioned this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select: 入力をリセットできるようにする
2 participants