Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): スクロールバーを常に表示に設定しているときの意図しないpaddingを除去 #1387

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

Qs-F
Copy link
Collaborator

@Qs-F Qs-F commented Jul 14, 2023

チケット

実装内容

  • Tableのスクロールバーの領域がスクロールが発生しないときも常にpaddingが設定されているのを修正

スクリーンショット

変更前 変更後
image image

相談内容(あれば)

@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2023

🦋 Changeset detected

Latest commit: 1949723

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@4design/for-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 14, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1949723
Status: ✅  Deploy successful!
Preview URL: https://d35f6ed4.for-ui.pages.dev
Branch Preview URL: https://fix-table-scroll-bar-padding.for-ui.pages.dev

View logs

@Qs-F Qs-F marked this pull request as ready for review July 14, 2023 01:33
@Qs-F Qs-F requested a review from locona July 14, 2023 01:33
Copy link
Contributor

@locona locona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Qs-F Qs-F merged commit 3b36925 into main Jul 24, 2023
@Qs-F Qs-F deleted the fix/table-scroll-bar-padding@1361 branch July 24, 2023 01:55
@github-actions github-actions bot mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table: スクロールバーを表示しているときの表示崩れ
2 participants