Add Modbus function 0x2B/0E Read DeviceIdentifiers, add get/set SlaveID, get/set ResponseTimeout, get . #185
+413
−245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extraneous whitespace, without any code change.
…eady marked to be eliminated, and its implementation was flawed. Comment out unneeded private members txBuffer, rxBuffer. Name the public member arguments; do not let the user guess which argument is what. Also do not require the user to consult the documentation. Include the small inline functions into ModbusMaster.h; this also eliminates the compilation warning about defined but unused crc16_update().
Add Debug option, to allow to see what actually is send and received, and if some rubbish is received between transmit and receive, which would point to hardware related issues.
Add method to change/request (get/set) the ResponseTimeout. Add method to request the response size of data in the response buffer. Add Modbus function 0x2B/0E Read DeviceIdentifiers ku8MBReadDeviceIdentifiers.
… receive() has now been fixed. Apparently never tested. This solves e15a1dc in a different, more robust way, by taking it out of the for loop and including the MaxBufferSize check. Fix description of getResponseSize().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add method to change/request (get/set) the SlaveID.
Add method to change/request (get/set) the ResponseTimeout.
Add method to request the response size of data in the response buffer.
Add Modbus function 0x2B/0E Read DeviceIdentifiers ku8MBReadDeviceIdentifiers.
Description
Several issues multiple users reported about are resolved
Issues Resolved
#183 Changing Slave ID
#182 ReadHoldingRegisters takes 2seconds
#144 BUG REPORT: does not compile with -Werror=uninitialized due to bug in ModbusMaster::requestFrom(...) ==> requestFrom method has been removed.
#135 removed set slave id function
#124 Set own timeout?
Check List
General
git diff --checkbefore committing.-> trailing whitespace removed as separate commit ac85132
The following have been modified to reflect new features, if warranted
The following have NOT been modified