Fix a duplicated header for inbox message #3955
Conversation
| @@ -1,5 +1,3 @@ | |||
| <% content_for :page_header_title, 'Message' %> | |||
There was a problem hiding this comment.
We already have the same exact line inside the provider/admin/messages/message template.
There was a problem hiding this comment.
So should it be removed from the template and ensure that it is always there by having it here? Just asking
There was a problem hiding this comment.
The provider/admin/messages/message partial is used in 2 other templates, so I guess it's better having it three to avoid duplication.
There was a problem hiding this comment.
I meant the opposite - remove from templates and keep in the partial (here). But either way, do as you feel
There was a problem hiding this comment.
I'm not sure we are understsanding each other 😬
So there is a partial with the header included
and it is used in:In addition, porta/app/views/provider/admin/messages/inbox/show.html.erb had its own <% content_for :page_header_title, 'Message' %> which was causing a duplication, and I removed that one.
What this PR does / why we need it:
This is a tiny fix that removes the double title.
Before:
After:
Which issue(s) this PR fixes
none
Verification steps
Special notes for your reviewer: