Fix amazon_s3.yml config for FILE_UPLOAD_STORAGE=filesystem #3909
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes a confusing behavior when
FILE_UPLOAD_STORAGE
is set tofilesystem
explicitly.It's not "broken" in the product, because it's assumed that when this env var is empty,
filesystem
is used, and when it'ss3
, then S3 is used for storage.But when
FILE_UPLOAD_STORAGE=filesystem
is set explicitly, the application isn't loaded, with the error:because the
amazon_s3.yml
doesn't have a:filesystem
alias.There are some references that hint that
filesystem
is a potential valid value forFILE_UPLOAD_STORAGE
:porta/openshift/system/.env
Line 85 in c0ec886
porta/config/examples/paperclip.yml
Line 16 in c0ec886
so I made some changes in the example config to prevent this config from failing.
Which issue(s) this PR fixes
-none-
Verification steps
Run the app with
FILE_UPLOAD_STORAGE=filesystem
and make sure no errors are thrown and the storage is set correctly.Special notes for your reviewer: