Add BUGSNAG_RELEASE_STAGE and use it in Bugsnag initializer #3123
Conversation
mayorova
force-pushed
the
add-bugsnag-release-stage
branch
from
2aa4f8a
to
0ce5375
Compare
mayorova
changed the title
config/initializers/bugsnag.rb
Outdated
| stages = Rails.configuration.three_scale.error_reporting_stages | ||
| config.notify_release_stages = stages if stages.present? | ||
| config.notify_release_stages = stages.present? ? stages : %w[production] |
There was a problem hiding this comment.
if we are not notified about errors, how would we know about them?
There was a problem hiding this comment.
We would get notified! Just need to set error_reporting_stages in settings.yml properly.
There was a problem hiding this comment.
why not add staging by default?
There was a problem hiding this comment.
Well, staging is an environment that only exists in SaaS world, so I don't know if there would be much benefit in adding it here. But we can do it also.
| @@ -11,6 +11,8 @@ base: &default | |||
| daily_weekly_reports_pref: <%= ENV.fetch('ENABLE_DAILY_WEEKLY_REPORTS_PREF', '1') == '1' %> | |||
| readonly_custom_domains_settings: <%= ENV.fetch('READONLY_CUSTOM_DOMAINS_SETTINGS', '1') == '1' %> | |||
| bugsnag_api_key: <%= ENV['BUGSNAG_API_KEY'] %> | |||
| bugsnag_release_stage: <%= ENV.fetch('BUGSNAG_RELEASE_STAGE', Rails.env) %> | |||
| error_reporting_stages: <%= ENV.fetch('ERROR_REPORTING_STAGES', 'production') %> | |||
There was a problem hiding this comment.
wait, maybe rename this to BUGSNAG_ENABLED_RELEASE_STAGES
There was a problem hiding this comment.
to make it more meaningful after bugsnag upgrade
There was a problem hiding this comment.
Well, this config (and environment variable) are not new - it already existed, I just moved it up.
I'd keep it as it is for now, and at some point (probably with the upgrade) rename both the environment variable, and the configuration name.
Just to reduce the amount of changes we do now.
This is a way to set a different
releaseStagemetadata on Bugsnag (e.g.staging), while still usingRAILS_ENV=production)NOTE: In order to use a different environment
Rails.configuration.three_scale.error_reporting_stages(insettings.yml) must be changed to include the new environment.This env var as added as default one in Bugsnag Ruby in 6.16, see the PR and the release notes.