Fix hardcoded value in the member permissions test (#3635)

* Fix hardcoded value in the member permissions test * Fix the test params
3scale · Nov 23, 2023 · ffc58d0 · ffc58d0
1 parent 893693b
commit ffc58d0
Showing 1 changed file with 83 additions and 78 deletions.
diff --git a/test/integration/admin/api/member_permissions_controller_test.rb b/test/integration/admin/api/member_permissions_controller_test.rb
@@ -6,200 +6,205 @@ class Admin::Api::MemberPermissionsControllerTest < ActionDispatch::IntegrationT
 
   setup do
     @provider = FactoryBot.create(:provider_account)
-    @services = FactoryBot.create_list(:simple_service, 2, account: @provider)
-    @user = FactoryBot.create(:active_user, account: @provider)
-    @token = FactoryBot.create(:access_token, owner: @provider.admin_users.first!, scopes: %w[account_management]).value
-
-    host! @provider.external_admin_domain
+    service_ids = FactoryBot.create_list(:simple_service, 2, account: provider).pluck(:id)
+    @service1_id = service_ids.first
+    @service2_id = service_ids.last
+    @nonexistent_id = service_ids.max + 1
+    @user = FactoryBot.create(:active_user, account: provider)
+    @token = FactoryBot.create(:access_token, owner: provider.admin_users.first!, scopes: %w[account_management]).value
+
+    host! provider.external_admin_domain
   end
 
+  attr_reader :provider, :service1_id, :service2_id, :nonexistent_id, :user, :token
+
   test 'get' do
-    get admin_api_permissions_path(id: @user.id, format: :json, access_token: @token)
+    get admin_api_permissions_path(id: user.id, format: :json, access_token: token)
     assert_response :success
   end
 
   test "PUT: enable 'analytics' section for service 1" do
-    params = { allowed_sections: ['monitoring'], allowed_service_ids: [@services.first.id], access_token: @token }
+    params = { allowed_sections: ['monitoring'], allowed_service_ids: [service1_id], access_token: token }
 
-    put admin_api_permissions_path(id: @user.id, format: :json), params: params
+    put admin_api_permissions_path(id: user.id, format: :json), params: params
 
     assert_not_nil(permissions = JSON.parse(response.body)['permissions'])
     assert_equal ['monitoring'], permissions['allowed_sections']
-    assert_equal [@services.first.id], permissions['allowed_service_ids']
+    assert_equal [service1_id], permissions['allowed_service_ids']
 
-    @user.member_permissions.reload
-    assert_equal [:monitoring], @user.allowed_sections.to_a
-    assert_equal [@services.first.id], @user.allowed_service_ids
+    user.member_permissions.reload
+    assert_equal [:monitoring], user.allowed_sections.to_a
+    assert_equal [service1_id], user.allowed_service_ids
   end
 
   test "PUT: enable 'settings', but keep the same services" do
-    @user.update({ allowed_sections: ['partners'], allowed_service_ids: [@services.first.id] })
-    params = { allowed_sections: ['settings'], access_token: @token }
+    user.update({ allowed_sections: ['partners'], allowed_service_ids: [service1_id] })
+    params = { allowed_sections: ['settings'], access_token: token }
 
-    put admin_api_permissions_path(id: @user.id, format: :json), params: params
+    put admin_api_permissions_path(id: user.id, format: :json), params: params
 
     assert_not_nil(permissions = JSON.parse(response.body)['permissions'])
     assert_equal ['settings'], permissions['allowed_sections']
-    assert_equal [@services.first.id], permissions['allowed_service_ids']
+    assert_equal [service1_id], permissions['allowed_service_ids']
 
-    @user.member_permissions.reload
-    assert_equal [:settings], @user.allowed_sections.to_a
-    assert_equal [@services.first.id], @user.allowed_service_ids
+    user.member_permissions.reload
+    assert_equal [:settings], user.allowed_sections.to_a
+    assert_equal [service1_id], user.allowed_service_ids
   end
 
   test "PUT: enable service 2, but keep the same sections" do
-    @user.update({ allowed_sections: ['partners'], allowed_service_ids: [@services.first.id] })
-    params = { allowed_service_ids: [@services.last.id.to_s], access_token: @token }
+    user.update({ allowed_sections: ['partners'], allowed_service_ids: [service1_id] })
+    params = { allowed_service_ids: [service2_id.to_s], access_token: token }
 
-    put admin_api_permissions_path(id: @user.id, format: :json), params: params
+    put admin_api_permissions_path(id: user.id, format: :json), params: params
 
     assert_not_nil(permissions = JSON.parse(response.body)['permissions'])
     assert_equal ['partners'], permissions['allowed_sections']
-    assert_equal [@services.last.id], permissions['allowed_service_ids']
+    assert_equal [service2_id], permissions['allowed_service_ids']
 
-    @user.member_permissions.reload
-    assert_equal [:partners], @user.allowed_sections.to_a
-    assert_equal [@services.last.id], @user.allowed_service_ids
+    user.member_permissions.reload
+    assert_equal [:partners], user.allowed_sections.to_a
+    assert_equal [service2_id], user.allowed_service_ids
   end
 
   test "PUT: enable 'settings' and enable all services" do
-    @user.update({ allowed_sections: ['partners'], allowed_service_ids: [@services.first.id] })
+    user.update({ allowed_sections: ['partners'], allowed_service_ids: [service1_id] })
     # allowed_sections%5B%5D=settings&allowed_service_ids%5B%5D
-    params = { allowed_sections: ['settings'], allowed_service_ids: '', access_token: @token }
+    params = { allowed_sections: ['settings'], allowed_service_ids: '', access_token: token }
 
-    put admin_api_permissions_path(id: @user.id, format: :json), params: params
+    put admin_api_permissions_path(id: user.id, format: :json), params: params
 
     assert_not_nil(permissions = JSON.parse(response.body)['permissions'])
     assert_equal ['settings'], permissions['allowed_sections']
     assert_nil permissions['allowed_service_ids']
 
-    @user.member_permissions.reload
-    assert_equal [:settings], @user.allowed_sections.to_a
-    assert_nil @user.allowed_service_ids
+    user.member_permissions.reload
+    assert_equal [:settings], user.allowed_sections.to_a
+    assert_nil user.allowed_service_ids
   end
 
   test "PUT: enable 'settings', but disable all services" do
-    @user.update({ allowed_service_ids: [@services.first.id] })
+    user.update({ allowed_service_ids: [service1_id] })
     # allowed_sections%5B%5D=settings&allowed_service_ids%5B%5D=%5B%5D
-    params = { allowed_sections: ['settings'], allowed_service_ids: ["[]"], access_token: @token }
+    params = { allowed_sections: ['settings'], allowed_service_ids: ["[]"], access_token: token }
 
-    put admin_api_permissions_path(id: @user.id, format: :json), params: params
+    put admin_api_permissions_path(id: user.id, format: :json), params: params
 
     assert_not_nil(permissions = JSON.parse(response.body)['permissions'])
     assert_equal ['settings'], permissions['allowed_sections']
     assert_empty permissions['allowed_service_ids']
 
-    @user.member_permissions.reload
-    assert_equal [:settings], @user.allowed_sections.to_a
-    assert_empty @user.allowed_service_ids
+    user.member_permissions.reload
+    assert_equal [:settings], user.allowed_sections.to_a
+    assert_empty user.allowed_service_ids
   end
 
   test "updating admin's permissions is not allowed" do
-    @user.update_attribute :role, 'admin'
-    params = { allowed_sections: ['monitoring'], allowed_service_ids: [@services.first.id], access_token: @token }
+    user.update_attribute :role, 'admin'
+    params = { allowed_sections: ['monitoring'], allowed_service_ids: [service1_id], access_token: token }
 
-    put admin_api_permissions_path(id: @user.id, format: :json), params: params
+    put admin_api_permissions_path(id: user.id, format: :json), params: params
 
     assert_response :forbidden
     assert_equal '{"status":"Forbidden"}', response.body
   end
 
   test "member user can't update his own permissions" do
-    @user.update_attribute :role, 'member'
-    token = FactoryBot.create(:access_token, owner: @user, scopes: %w[account_management]).value
+    user.update_attribute :role, 'member'
+    token = FactoryBot.create(:access_token, owner: user, scopes: %w[account_management]).value
     # allowed_sections%5B%5D=settings&allowed_service_ids%5B%5D
     params = { allowed_sections: ['settings'], allowed_service_ids: '', access_token: token }
 
-    put admin_api_permissions_path(id: @user.id, format: :json), params: params
+    put admin_api_permissions_path(id: user.id, format: :json), params: params
 
     assert_response :forbidden
     assert_equal '{"error":"Your access token does not have the correct permissions"}', response.body
   end
 
   # this is managed by CanCan abilities
   test "member user can't update other users' permissions" do
-    logged_in_user = @provider.admins.first
+    logged_in_user = provider.admins.first
     logged_in_user.update_attribute :role, 'member'
-    another_user = FactoryBot.create(:user, account: @provider)
+    another_user = FactoryBot.create(:user, account: provider)
     # allowed_sections%5B%5D=settings&allowed_service_ids%5B%5D
-    params = { allowed_sections: ['settings'], allowed_service_ids: '', access_token: @token }
+    params = { allowed_sections: ['settings'], allowed_service_ids: '', access_token: token }
 
     put admin_api_permissions_path(id: another_user.id, format: :json), params: params
 
     assert_response :forbidden
   end
 
   test "PUT: setting an invalid allowed section" do
-    @user.update({ allowed_sections: ['partners'], allowed_service_ids: [@services.first.id] })
-    params = { allowed_sections: ['invalid'], access_token: @token }
+    user.update({ allowed_sections: ['partners'], allowed_service_ids: [service1_id] })
+    params = { allowed_sections: ['invalid'], access_token: token }
 
-    put admin_api_permissions_path(id: @user.id, format: :json), params: params
+    put admin_api_permissions_path(id: user.id, format: :json), params: params
 
     assert_response :success
     assert_not_nil(permissions = JSON.parse(response.body)['permissions'])
     assert_empty permissions['allowed_sections']
-    assert_equal [@services.first.id], permissions['allowed_service_ids']
+    assert_equal [service1_id], permissions['allowed_service_ids']
 
-    @user.member_permissions.reload
-    assert_empty @user.allowed_sections.to_a
-    assert_equal [@services.first.id], @user.allowed_service_ids
+    user.member_permissions.reload
+    assert_empty user.allowed_sections.to_a
+    assert_equal [service1_id], user.allowed_service_ids
   end
 
   test "PUT: one of the allowed section is invalid" do
-    @user.update({ allowed_sections: ['partners'], allowed_service_ids: [@services.first.id] })
-    params = { allowed_sections: %w[invalid settings], access_token: @token }
+    user.update({ allowed_sections: ['partners'], allowed_service_ids: [service1_id] })
+    params = { allowed_sections: %w[invalid settings], access_token: token }
 
-    put admin_api_permissions_path(id: @user.id, format: :json), params: params
+    put admin_api_permissions_path(id: user.id, format: :json), params: params
 
     assert_response :success
     assert_not_nil(permissions = JSON.parse(response.body)['permissions'])
     assert_equal ['settings'], permissions['allowed_sections']
-    assert_equal [@services.first.id], permissions['allowed_service_ids']
+    assert_equal [service1_id], permissions['allowed_service_ids']
 
-    @user.member_permissions.reload
-    assert_equal [:settings], @user.allowed_sections.to_a
-    assert_equal [@services.first.id], @user.allowed_service_ids
+    user.member_permissions.reload
+    assert_equal [:settings], user.allowed_sections.to_a
+    assert_equal [service1_id], user.allowed_service_ids
   end
 
   test "PUT: setting services, when some are non-existent only enables existent ones" do
-    @user.update({ allowed_sections: ['partners'], allowed_service_ids: [@services.first.id] })
-    params = { allowed_service_ids: [[@services.last.id.to_s],'22'], access_token: @token }
+    user.update({ allowed_sections: ['partners'], allowed_service_ids: [service1_id] })
+    params = { allowed_service_ids: [service2_id.to_s, nonexistent_id.to_s], access_token: token }
 
-    put admin_api_permissions_path(id: @user.id, format: :json), params: params
+    put admin_api_permissions_path(id: user.id, format: :json), params: params
 
     assert_response :success
     assert_not_nil(permissions = JSON.parse(response.body)['permissions'])
     assert_equal ['partners'], permissions['allowed_sections']
-    assert_equal [@services.last.id], permissions['allowed_service_ids']
+    assert_equal [service2_id], permissions['allowed_service_ids']
 
-    @user.member_permissions.reload
-    assert_equal [:partners], @user.allowed_sections.to_a
-    assert_equal [@services.last.id], @user.allowed_service_ids
+    user.member_permissions.reload
+    assert_equal [:partners], user.allowed_sections.to_a
+    assert_equal [service2_id], user.allowed_service_ids
   end
 
   test "PUT: setting non-existent services disables all" do
-    @user.update({ allowed_sections: ['partners'], allowed_service_ids: [@services.first.id] })
-    params = { allowed_service_ids: ['22'], access_token: @token }
+    user.update({ allowed_sections: ['partners'], allowed_service_ids: [service1_id] })
+    params = { allowed_service_ids: [nonexistent_id.to_s], access_token: token }
 
-    put admin_api_permissions_path(id: @user.id, format: :json), params: params
+    put admin_api_permissions_path(id: user.id, format: :json), params: params
 
     assert_response :success
     assert_not_nil(permissions = JSON.parse(response.body)['permissions'])
     assert_equal ['partners'], permissions['allowed_sections']
     assert_empty permissions['allowed_service_ids']
 
-    @user.member_permissions.reload
-    assert_equal [:partners], @user.allowed_sections.to_a
-    assert_empty @user.allowed_service_ids
+    user.member_permissions.reload
+    assert_equal [:partners], user.allowed_sections.to_a
+    assert_empty user.allowed_service_ids
   end
 
   test 'disable all allowed_sections' do
-    @user.update({ allowed_sections: ['partners'], allowed_service_ids: [@services.first.id] })
+    user.update({ allowed_sections: ['partners'], allowed_service_ids: [service1_id] })
 
-    put admin_api_permissions_path(id: @user.id, format: :json, access_token: @token), params: { allowed_sections: ['[]'] }
+    put admin_api_permissions_path(id: user.id, format: :json, access_token: token), params: { allowed_sections: ['[]'] }
 
-    @user.member_permissions.reload
-    assert_empty @user.allowed_sections.to_a
+    user.member_permissions.reload
+    assert_empty user.allowed_sections.to_a
   end
 
 end