[cli] do not crash when listing unaccessible directories #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -13,14 +13,17 @@ local co_yield = coroutine.yield | |||
| local co_create = coroutine.create | |||
| local co_resume = coroutine.resume | |||
|
|
|||
| local noop = function (err) end | |||
mikz
force-pushed
the
cli-filesystem-permission-error
branch
from
b824986 to
fd1f8a8
Compare
When the directory is not accessible, instead of crash like: ``` lua coroutine: runtime error: /opt/app-root/src/src/apicast/cli/filesystem.lua:50: attempt to call a nil value ``` Get a debug log like: ``` /usr/local/share/lua/5.1/lfs.lua:513: cannot open /usr/local/openresty/nginx/fastcgi_temp : Permission denied ```
davidor
approved these changes
Sep 3, 2018
mikz
force-pushed
the
cli-filesystem-permission-error
branch
from
fd1f8a8 to
c52896d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the directory is not accessible, instead of crash like:
Get a debug log like: