Merge pull request #865 from 3scale/cli-filesystem-permission-error

[cli] do not crash when listing unaccessible directories

CHANGELOG.md

@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased]
 
+## Fixed
+
+- Capture permission errors when searching for files on filesystem [PR #865](https://github.com/3scale/apicast/pull/865)
+
 ## [3.3.0-beta1] - 2018-08-31
 
 ### Added

gateway/src/apicast/cli/filesystem.lua

@@ -13,14 +13,17 @@ local co_yield = coroutine.yield
 local co_create = coroutine.create
 local co_resume = coroutine.resume
 
+local noop = function () end
+
 --- Safely try to get directory iterator
 local function ldir(dir)
   local ok, iter, state = pcall(pl_path_dir, dir)
 
   if ok then
     return iter, state
   else
-    return nil, iter
+    ngx.log(ngx.DEBUG, 'error listing directory: ', dir, ' err: ', iter)
+    return noop
   end
 end